Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): Update button on publish modal is always disabled on first time #1150

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(web): Update button on publish modal is always disabled on first time #1150

merged 1 commit into from
Sep 20, 2024
+12 −4

Conversation

m-abe-dev
Copy link
Contributor

@m-abe-dev m-abe-dev commented Sep 19, 2024 •
edited by coderabbitai bot
Loading

Overview

https://www.notion.so/eukarya/BUG-Update-button-on-publish-modal-is-always-disabled-on-first-time-10616e0fb16580b7878dcf1dc3321d25

What I've done

スクリーンショット 2024-09-19 17 17 55

What I haven't done

How I tested

Which point I want you to review particularly

Memo

Summary by CodeRabbit

  • New Features

    • Improved alias management in the Publish Tools Panel, ensuring that aliases are generated and validated when the modal is opened.

  • Bug Fixes

    • Enhanced responsiveness of alias updates to modal state changes, ensuring valid aliases are always presented.

@github-actions github-actions bot requested a review from pyshx September 19, 2024 15:18
@github-actions github-actions bot added the web label Sep 19, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 19, 2024 •
edited
Loading

✅ Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit 30fb7bd
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/66ed75ab33121200082b54c8
😎 Deploy Preview https://deploy-preview-1150--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Sep 19, 2024 •
edited
Loading

Walkthrough

The changes modify the management of the alias state in the component by replacing the useMemo hook with a useState hook. The alias is now initialized directly from project?.alias or generated using the generateAlias function. A new useEffect hook monitors changes to modalOpen, generating a new alias if the current one is empty and invoking handleProjectAliasCheck. This ensures that the alias is consistently valid and verified when the modal is active.

Changes

File Path Change Summary
web/src/beta/features/Editor/Publish/PublishToolsPanel/hooks.ts Changed alias declaration from useMemo to useState, added useEffect to manage alias updates based on modalOpen.

Suggested reviewers

  • mkumbobeaty
  • airslice

Poem

In the garden where aliases bloom,
A state change brings light to the room.
With each modal that opens wide,
New names sprout, like a joyful tide.
Hopping along, we cheer and play,
For every alias, a bright new day! 🐇✨

Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between ab71ba7 and 30fb7bd.

Files selected for processing (1)
  • web/src/beta/features/Editor/Publish/PublishToolsPanel/hooks.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • web/src/beta/features/Editor/Publish/PublishToolsPanel/hooks.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@m-abe-dev m-abe-dev changed the title fix: publish button for publish modal Chore: Update button on publish modal is always disabled on first time Sep 19, 2024
@m-abe-dev m-abe-dev changed the title Chore: Update button on publish modal is always disabled on first time chore: [BUG] Update button on publish modal is always disabled on first time Sep 19, 2024
@airslice airslice changed the title chore: [BUG] Update button on publish modal is always disabled on first time fix(web): Update button on publish modal is always disabled on first time Sep 20, 2024
@m-abe-dev m-abe-dev merged commit d428b46 into main Sep 20, 2024
13 checks passed
@m-abe-dev m-abe-dev deleted the fix/update_button_for_modal branch September 20, 2024 13:23
This was referenced Nov 11, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@airslice airslice airslice approved these changes

@mkumbobeaty mkumbobeaty Awaiting requested review from mkumbobeaty mkumbobeaty is a code owner

@pyshx pyshx Awaiting requested review from pyshx

Assignees

@m-abe-dev m-abe-dev

Labels
web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-abe-dev @airslice